[core] Do not select template instances if their template arguments are invalid decls in the AST#19002
Merged
dpiparo merged 4 commits intoroot-project:masterfrom Jun 14, 2025
Merged
Conversation
and only forward declared.
Member
|
Any chance for writing a test? |
Member
Author
|
You are right @vgvassilev , we need one and it's not too hard to write. |
in presence of selected template instances with template arguments that are represented in the AST as invalid.
Test Results 19 files 19 suites 3d 10h 46m 31s ⏱️ For more details on these failures, see this check. Results for commit e5b6bee. |
Member
|
@smuzaffar, can we give this a try on cmssw scale? |
Contributor
|
sure, CMSSW tests are running via cms-sw#223 |
Member
Author
|
@smuzaffar thanks a lot. I see some failures but can't judge if they are caused by these changes: what would be your verdict? |
Contributor
|
CMSSW tests look good for this. The unit tests failure during PR tests are not related to this change ( we already have those unit tests failing for cmssw IBs) |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for example, when they are only forward declared.
Side effect: less lookups are carried out during the selection, therefore less memory and runtime is used for dictionary generation.
Fixes #18982